-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: add CI step to detect generate script diffs #1405
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1405 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 2166 2166
Lines 237442 237442
Branches 1040 1040
=======================================
Hits 236535 236535
Misses 886 886
Partials 21 21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not detect deleted files, but I'm not sure whether this is necessary.
I didn't give it enough thought.
|
To be able to detect deleted files, the method of checking for diffs has been changed to the following command.
|
I tried to run it in my fork and it doesn't work: You might need the PR write permission for that action. Please assign it for the lowest possible scope (e.g. only for this single job). |
I gave permissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shinigami92 Is these Jsdocs what you intended with your request?
Maybe you could give an example of what you would like to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside that, I think we are good to go 👍
So I will already approve so other maintainers know that it counts after you fixed the dep version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to .gitginore
the transpiled .js
script?
- If yes, why is the script not failing?
- If not, why not?
Ah I see, because it is transpiled only after the check. (I plan to use your script as a template to automate some more tasks 😻 ) |
That sounds nice! |
@sunadoi It looks like this breaks the main branch. |
#813
After running the
generate:locales
command in the workflow/ci pipeline, check for some uncommitted diffs with the following command.--exit-code
option causes it to fail if there are any diffs.I tested this CI on my repository.
It seems to work well.
ref: https://github.com/sunadoi/faker/actions/runs/3164634036/jobs/5153063988